fix(specs): allow JSON array for aroundPrecision
#1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
commented
Jul 31, 2023
| x-categories: | ||
| - Geo-Search | ||
|
|
||
| aroundPrecisionFromValue: |
There was a problem hiding this comment.
@kai687 I did not found occurrences of documentation for this specific type, is there a place where I could find some info? If not, would you mind suggesting a description for the from and value parameters?
|
Is one of the formats a legacy format ? if yes, maybe we don't have to support them all ! |
I tried on the API and it's still there so I belive it's a different use case |
aallam
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
See sandbox
aroundPrecisioncan either be an integer or a JSON array.Today this is supported in the JS and C# clients, but not in the others, since the API allows it we should also reflect it in the specs.