Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): allow partial input update for authentications #1856

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix(specs): allow partial input update for authentications #1856

merged 1 commit into from
Aug 1, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jul 31, 2023 •
edited by jira bot

🧭 What and Why

🎟 JIRA Ticket: DI-1239

Changes included:

  • auth input partial descriptions

@Fluf22 Fluf22 requested a review from a team as a code owner July 31, 2023 13:42
@Fluf22 Fluf22 self-assigned this Jul 31, 2023
@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ae33695
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64c7d025ea45df000884c634
😎 Deploy Preview https://deploy-preview-1856--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 31, 2023 •
edited

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 requested a review from millotp July 31, 2023 15:34
millotp
millotp approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make two separate object desc for each input type

that's what I feared, we have a similar pattern in other places and I'd love to find a better way of doing it, maybe with some custom logic at some point, but this works best for every language

shortcuts
shortcuts approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg!

@shortcuts shortcuts merged commit 58ea5db into main Aug 1, 2023
21 checks passed
@shortcuts shortcuts deleted the fix/patch-auth-input branch August 1, 2023 06:56
@Fluf22
Copy link
Contributor Author

Fluf22 commented Aug 1, 2023

@millotp the best would be to just have Partial<MyStruct> in ts 😁 but how could this be replicated in other languages? 🤔🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fluf22 @algolia-bot @millotp @shortcuts