Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): delete Predict #1860

Merged
merged 6 commits into from
Aug 2, 2023
Merged

feat(specs): delete Predict #1860

merged 6 commits into from
Aug 2, 2023

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 1, 2023

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

As discussed with @francoischalifour, we should be able to move forward with Predict's client and specs deletion.

https://www.npmjs.com/package/@algolia/predict have been deprecated

@shortcuts shortcuts self-assigned this Aug 1, 2023
@shortcuts shortcuts requested a review from a team as a code owner August 1, 2023 15:33
@shortcuts shortcuts requested review from damcou and Fluf22 August 1, 2023 15:33
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ba0abaf
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64ca045582c869000761779f
😎 Deploy Preview https://deploy-preview-1860--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 1, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@shortcuts shortcuts merged commit a5bf623 into main Aug 2, 2023
24 checks passed
@shortcuts shortcuts deleted the feat/delete-predict branch August 2, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants