Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dart): add search wait task methods #2037

Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat(dart): add search wait task methods #2037

merged 3 commits into from
Sep 26, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Sep 22, 2023

Changes included:

Add missing wait task methods:

  • waitTask
  • waitKeyCreation
  • waitKeyUpdate
  • waitKeyDeletion

@netlify
Copy link

netlify bot commented Sep 22, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 34acfc0
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/651199972e65880008ecf332
😎 Deploy Preview https://deploy-preview-2037--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 22, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@aallam aallam marked this pull request as ready for review September 25, 2023 09:29
@aallam aallam requested a review from a team as a code owner September 25, 2023 09:29
@aallam aallam enabled auto-merge (squash) September 25, 2023 09:29
@aallam aallam changed the title feat(dart): add wait task methods feat(dart): add search wait task methods Sep 25, 2023
millotp
millotp reviewed Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !
I'm not sure if we are still updating this doc, but it could be nice to have a code snippet for this, because it won't be auto generated with the CTS

@aallam
Copy link
Member Author

aallam commented Sep 25, 2023

looks good ! I'm not sure if we are still updating this doc, but it could be nice to have a code snippet for this, because it won't be auto generated with the CTS

Yes, it's part #1984

@aallam aallam requested a review from millotp September 26, 2023 08:01
millotp
millotp approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great !

@aallam aallam merged commit 3f7276e into main Sep 26, 2023
15 checks passed
@aallam aallam deleted the feat/dart-wait-task branch September 26, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aallam @algolia-bot @millotp