Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): Add failureThreshold to Task and TaskUpdate types #2144

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Oct 17, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-1601

Changes included:

  • Add failureThreshold to Task and TaskUpdate types

@damcou damcou self-assigned this Oct 17, 2023
@damcou damcou requested a review from a team as a code owner October 17, 2023 11:57
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b6d72e8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/652e918add0d19000767a48f
😎 Deploy Preview https://deploy-preview-2144--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 17, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@damcou damcou changed the title feat(ingestion): Add failureThreshold to Task and TaskUpdate types feat(specs): Add failureThreshold to Task and TaskUpdate types Oct 17, 2023
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Can you also add it to the Run object please ? it's also returned by the api

@damcou damcou requested a review from millotp October 17, 2023 12:22
@damcou damcou enabled auto-merge (squash) October 17, 2023 12:38
@damcou damcou merged commit dcd1201 into main Oct 17, 2023
20 checks passed
@damcou damcou deleted the feat/DI-1601/add-threshold-to-types branch October 17, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants