Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(specs): insights identify #2182

Merged
merged 2 commits into from
Oct 23, 2023
Merged

revert(specs): insights identify #2182

merged 2 commits into from
Oct 23, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Oct 23, 2023

Changes included:

Revert adding Identify event .

@aallam aallam requested a review from a team as a code owner October 23, 2023 08:23
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d393a39
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/653630505ed0ff000859e86a
😎 Deploy Preview https://deploy-preview-2182--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 23, 2023 •
edited

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@aallam aallam enabled auto-merge (squash) October 23, 2023 08:31
millotp
millotp approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, is there a jira ticket for this ?

@aallam aallam merged commit 517f9cb into main Oct 23, 2023
23 checks passed
@aallam aallam deleted the revert/indentify branch October 23, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aallam @algolia-bot @millotp