chore(clients): add more e2e #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
approved these changes
Jan 8, 2024
millotp
reviewed
Jan 8, 2024
| @@ -40,7 +40,7 @@ async function runCtsOne(language: string): Promise<void> { | |||
| }); | |||
| break; | |||
| case 'ruby': | |||
| await run(`bundle install && bundle exec rake test`, { cwd: 'tests/output/ruby' }); | |||
| await run(`bundle install && bundle exec rake test --trace`, { cwd: 'tests/output/ruby' }); | |||
There was a problem hiding this comment.
maybe we don't want to keep this
There was a problem hiding this comment.
It helped me debugging but it's really verbose, up to you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
add more e2e to some frequently methods used on the clients, I'll add some save e2e later on