fix(javascript): engine support node > 14 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
|
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 2a1bea6 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6232f53fc0540e0008d0007c |
|
✗ The generated branch has been deleted. If the PR has been merged, you can check the generated code on the |
|
Ok I just realized I pushed the generated code, we might want to check the diff with the target branch and not the current one 🤔 |
shortcuts
force-pushed
the
fix/javascript-engines
branch
from
a724631
to
7c36b28
Compare
bodinsamuel
approved these changes
Mar 17, 2022
This was referenced Mar 22, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
The caret only works for patch versions, which does not allow users to use Node 16 for example.
🧪 Test