Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swift): cts client #2610

Merged
merged 12 commits into from Jan 30, 2024
Merged

feat(swift): cts client #2610

merged 12 commits into from Jan 30, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jan 26, 2024 •
edited by jira bot

🧭 What and Why

🎟 JIRA Ticket: DI-1745 DI-1787

Changes included:

  • handle unique host for monitoring client
  • removed CTS requests from the codebase
  • CTS client
  • linux CTS handling
  • actually run the CTS on the CI

@Fluf22 Fluf22 self-assigned this Jan 26, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 26, 2024 •
edited

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5162e63
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65b8ae2f2fcd8b00089a47cb
😎 Deploy Preview https://deploy-preview-2610--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 26, 2024 •
edited

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 26, 2024

I don't know why the commit history is all fucked up like this :'( I'll try to clean it up later...

@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 29, 2024

Git history restored ✅
Cleaned up generated files from the base ✅

@Fluf22 Fluf22 marked this pull request as ready for review January 29, 2024 15:48
@Fluf22 Fluf22 requested a review from a team as a code owner January 29, 2024 15:48
millotp
millotp reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

scripts/cts/runCts.ts Show resolved Hide resolved
generators/src/main/java/com/algolia/codegen/cts/tests/TestsClient.java Show resolved Hide resolved
templates/swift/tests/client/suite.mustache Show resolved Hide resolved
clients/algoliasearch-client-swift/Sources/Core/Helpers/Version.swift Outdated Show resolved Hide resolved
templates/swift/tests/client/suite.mustache Show resolved Hide resolved
tests/output/swift/Tests/requests/AbtestingTests.swift Outdated Show resolved Hide resolved
millotp
millotp approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@morganleroi
Copy link
Contributor

Yeahhhhhhh GG

@Fluf22 Fluf22 enabled auto-merge (squash) January 30, 2024 08:07
@Fluf22 Fluf22 merged commit 4e245fe into main Jan 30, 2024
28 checks passed
@Fluf22 Fluf22 deleted the feat/swift-cts-client branch January 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fluf22 @algolia-bot @morganleroi @millotp