Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): add e2e tests for analytics API #2737

Merged
merged 1 commit into from Feb 19, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 19, 2024

🧭 What and Why

Simple e2e to make sure the analytics API is called correctly, and that query params encoding is working properly.

Note: the scope of the PR is not very correct but it's just to trigger a release of all languages.

@millotp millotp requested a review from a team as a code owner February 19, 2024 12:41
@millotp millotp self-assigned this Feb 19, 2024
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 96aba12
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65d34c88e6539b000882487d
😎 Deploy Preview https://deploy-preview-2737--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 19, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

@millotp millotp merged commit ef37e65 into main Feb 19, 2024
27 checks passed
@millotp millotp deleted the fix/analytics-e2e branch February 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants