Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add CustomFields to CT Source Input #2742

Merged
merged 9 commits into from Feb 20, 2024
Merged

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Feb 20, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-1788

Changes included:

@damcou damcou self-assigned this Feb 20, 2024
@damcou damcou requested a review from a team as a code owner February 20, 2024 10:12
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit e6406ad
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65d48bf8bb18500008c88b75
😎 Deploy Preview https://deploy-preview-2742--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 20, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp previously approved these changes Feb 20, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! maybe a small description on CommercetoolsCustomFields won't hurt 😛

required:
- url
- projectKey

CommercetoolsCustomFields:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortcuts
shortcuts previously approved these changes Feb 20, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@millotp millotp merged commit 6624759 into main Feb 20, 2024
26 checks passed
@millotp millotp deleted the DI-1788/ct-customfields branch February 20, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants