Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clients): browse synonyms page not in response #2757

Merged
merged 3 commits into from Feb 21, 2024
Merged

fix(clients): browse synonyms page not in response #2757

merged 3 commits into from Feb 21, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Feb 21, 2024 •
edited

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Catched by fluffman the page parameter doesn't exist in the synonyms response

@shortcuts shortcuts self-assigned this Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d5a15d0
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65d63c07338ac90008cc25ef
😎 Deploy Preview https://deploy-preview-2757--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 21, 2024 •
edited

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review February 21, 2024 18:31
@shortcuts shortcuts requested a review from a team as a code owner February 21, 2024 18:31
Fluf22
Fluf22 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s go

@shortcuts shortcuts merged commit 92cd1c7 into main Feb 21, 2024
19 checks passed
@shortcuts shortcuts deleted the fix/clients-browse-synonyms branch February 21, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shortcuts @algolia-bot @Fluf22