Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swift): last missing helpers #2764

Merged
merged 19 commits into from Feb 26, 2024
Merged

feat(swift): last missing helpers #2764

merged 19 commits into from Feb 26, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Feb 22, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-1746 & DI-1778 & DI-1842

Changes included:

  • replaceAllObjects
  • generateSecuredAPIKey

🧪 Tests

  • added manual test for the methods
  • added an e2e to test replaceAllObjects (it also uses the chunked batch method from time to time)

@Fluf22 Fluf22 self-assigned this Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit eb16a8d
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65dcaa02cb714e000860a9e6
😎 Deploy Preview https://deploy-preview-2764--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 22, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 marked this pull request as ready for review February 23, 2024 10:09
@Fluf22 Fluf22 requested a review from a team as a code owner February 23, 2024 10:09
@Fluf22 Fluf22 marked this pull request as draft February 23, 2024 10:10
@Fluf22 Fluf22 marked this pull request as ready for review February 23, 2024 16:34
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great !

@Fluf22 Fluf22 requested a review from millotp February 26, 2024 12:25
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks super nice

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, my last comment is a nitpick non blocking

@Fluf22 Fluf22 enabled auto-merge (squash) February 26, 2024 15:50
@Fluf22 Fluf22 merged commit a5cbe7d into main Feb 26, 2024
27 checks passed
@Fluf22 Fluf22 deleted the feat/swift-manual-helpers branch February 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants