Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(javascript): broken tests #2767

Merged
merged 1 commit into from
Feb 23, 2024
Merged

chore(javascript): broken tests #2767

merged 1 commit into from
Feb 23, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

seems like I merged with a broken test https://github.com/algolia/api-clients-automation/actions/runs/8020801101/job/21911507593, this PR tries to fix it

@shortcuts shortcuts self-assigned this Feb 23, 2024
@shortcuts shortcuts requested a review from a team as a code owner February 23, 2024 14:59
Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ba5d279
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65d8b2c396ff21000855167a
😎 Deploy Preview https://deploy-preview-2767--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it random ?

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 23, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts
Copy link
Member Author

is it random ?

it shouldn't be but I just saw the PR was merged with the broken test because of the same matrix issue as usual

@shortcuts shortcuts merged commit 350e01c into main Feb 23, 2024
17 checks passed
@shortcuts shortcuts deleted the chore/wrong-test branch February 23, 2024 15:12
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Feb 23, 2024
algolia/api-clients-automation#2767

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants