Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): allow custom connect timeout #3010

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

we don't allow custom connect timeouts with request options on the javascript client, we can make it more flexible

@shortcuts shortcuts self-assigned this Apr 15, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 15, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean

Copy link

@github-actions github-actions bot temporarily deployed to pull request April 15, 2024 14:49 Inactive
@shortcuts shortcuts marked this pull request as ready for review April 15, 2024 14:50
@shortcuts shortcuts requested a review from a team as a code owner April 15, 2024 14:50
@shortcuts shortcuts merged commit 96e6206 into main Apr 15, 2024
16 checks passed
@shortcuts shortcuts deleted the feat/custom-timeouts-javascript branch April 15, 2024 14:51
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 15, 2024
algolia/api-clients-automation#3010

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants