Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swift): add privacy manifest #3039

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Apr 23, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • add newly required Apple privacy manifest

@Fluf22 Fluf22 self-assigned this Apr 23, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner April 23, 2024 17:33
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 23, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 requested a review from aallam April 23, 2024 17:35
Copy link

github-actions bot commented Apr 23, 2024

@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 17:47 Inactive
shortcuts
shortcuts previously approved these changes Apr 23, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes oki nice

@aallam
Copy link
Member

aallam commented Apr 24, 2024

I think PrivacyInfo.xcprivacy should be added to Package.swift and AlgoliaSearchClient.podspec

@Fluf22
Copy link
Contributor Author

Fluf22 commented Apr 24, 2024

I already did it on this repo, but I think I did not on the legacy one 😱 Gonna go check it out

Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Fluf22 Fluf22 enabled auto-merge (squash) April 24, 2024 13:39
@github-actions github-actions bot temporarily deployed to pull request April 24, 2024 14:21 Inactive
@Fluf22 Fluf22 merged commit 3aaa277 into main Apr 24, 2024
13 checks passed
@Fluf22 Fluf22 deleted the chore/swift-privacy-manifest branch April 24, 2024 14:23
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Apr 24, 2024
algolia/api-clients-automation#3039

Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants