Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): simplify filter types #3042

Merged
merged 9 commits into from
Apr 30, 2024
Merged

fix(specs): simplify filter types #3042

merged 9 commits into from
Apr 30, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 26, 2024

🧭 What and Why

Use recursive types to avoid creating in unnecessary oneOf and allow to use the full potential of the filters

@millotp millotp self-assigned this Apr 26, 2024
@millotp millotp requested a review from a team as a code owner April 26, 2024 15:34
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 26, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

@github-actions github-actions bot temporarily deployed to pull request April 30, 2024 10:24 Inactive
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insane feature gg

@additional_properties.each_pair do |k, v|
transformed_hash[k.to_sym] = v
end unless @additional_properties.nil?
# add extra attribute to transformed_hash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge fix

@millotp millotp merged commit 1250c2b into main Apr 30, 2024
25 checks passed
@millotp millotp deleted the fix/filters branch April 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants