Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contribution guideline #3057

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented May 3, 2024

🧭 What and Why

This PR updates the guidelines for writing long descriptions.
Essentially, don't use Markdown in the first sentence/paragraph in the descriptions.

The Algolia CLI uses the Search API spec to generate flags from the API parameter/index settings. The help text is generated from the first sentence of the description key.

It looks better on the command line if the help text doesn't contain Markdown.

For the most part, I already updated the specs with that in mind. There are some Markdown links, but they will be automatically removed when generating the flags and help text.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 3, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@kai687 kai687 marked this pull request as ready for review May 3, 2024 12:49
@kai687 kai687 requested a review from a team as a code owner May 3, 2024 12:49
@kai687 kai687 requested review from morganleroi and millotp May 3, 2024 12:49
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea !

Copy link

github-actions bot commented May 3, 2024

@github-actions github-actions bot temporarily deployed to pull request May 3, 2024 12:52 Inactive
@kai687
Copy link
Contributor Author

kai687 commented May 8, 2024

@millotp could you merge this for me please? I don't have permissions.

@shortcuts shortcuts merged commit 5c473cc into main May 8, 2024
13 checks passed
@shortcuts shortcuts deleted the docs/long-descriptions branch May 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants