You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollup uses openapitools.json to build js clients, but the file is only in the monorepo. When the rollup runs at algoliasearch-client-javascript repository, it doesn't have access to the file, and the build fails.
This PR copies the file to the js repo on release, but I'm not 100% sure if this is the best way. I'm open to alternative ways. If not, this won't be a terrible idea, though.
I think having generation related code in client repo is a bad idea, I think it would be better to make rollup.config.js a generated file, because openapitools.json is only used to build the client list line 112 which should be possible to generate.
We might as well hardcode the client list in rollup.config.json rather than copying the whole file from openapi, wdyt ?
I think having generation related code in client repo is a bad idea, I think it would be better to make rollup.config.js a generated file, because openapitools.json is only used to build the client list line 112 which should be possible to generate. We might as well hardcode the client list in rollup.config.json rather than copying the whole file from openapi, wdyt ?
Now that I hear you, what about this? During the release process, we generate a file like release.config.json right next to rollup.config.js. And rollup can import it. The rollup config stays manually written, but only that json file gets updated by the release process. It sounds like the middle ground of two suggestions you just made. WDYT?
Actually we don't even need an other file, the information is already in the repo, we just need to iterate through the folders name in packages and that the final list (minus client-common, requester-browser-xhr, requester-node-http that can be hardcoded and filtered out)
The reason will be displayed to describe this comment to others. Learn more.
Looking great !
eunjae-lee
changed the title
chore(javascript): add openapitools.json to js repository
chore(javascript): remove dependency to openapitools.json at rollup
Apr 1, 2022
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eunjae-lee
changed the title
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-211
Changes included:
rollupusesopenapitools.jsonto build js clients, but the file is only in the monorepo. When the rollup runs atalgoliasearch-client-javascriptrepository, it doesn't have access to the file, and the build fails.This PR copies the file to the js repo on release, but I'm not 100% sure if this is the best way. I'm open to alternative ways. If not, this won't be a terrible idea, though.