Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(javascript): fix ts-node issue #368

Merged
merged 6 commits into from
Apr 12, 2022
Merged

chore(javascript): fix ts-node issue #368

merged 6 commits into from
Apr 12, 2022

Conversation

eunjae-lee
Copy link
Contributor

🧭 What and Why

Changes included:

ts-node fails to run publish.ts file because module in tsconfig.json is esnext. So we introduce a separate tsconfig file just for the script.

@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 5528ba0
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6255941a371ed80008d6555e

@eunjae-lee eunjae-lee changed the title Chore/ts-node chore(javascript): fix ts-node issue Apr 11, 2022
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 11, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@eunjae-lee eunjae-lee marked this pull request as ready for review April 12, 2022 08:13
@eunjae-lee eunjae-lee requested review from a team, damcou and shortcuts and removed request for a team April 12, 2022 08:13
shortcuts
shortcuts previously approved these changes Apr 12, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking bon!

@eunjae-lee eunjae-lee enabled auto-merge (squash) April 12, 2022 15:00
@eunjae-lee eunjae-lee merged commit 1607d96 into main Apr 12, 2022
@eunjae-lee eunjae-lee deleted the chore/ts-node branch April 12, 2022 15:08
@eunjae-lee eunjae-lee mentioned this pull request Apr 15, 2022
1 task
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
* chore(javascript): fix ts-node issue

* chore: add .prettierrc to js package

* chore: add .prettierignore to js client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants