Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): add missing descriptions #416

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix(javascript): add missing descriptions #416

merged 2 commits into from
Apr 25, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 22, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-443

Changes included:

Follow up of #415, splitting some changes from #413

Some type descriptions are missing, and some weird new lines were kept.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team April 22, 2022 12:32
@shortcuts shortcuts self-assigned this Apr 22, 2022
@shortcuts shortcuts requested review from damcou and millotp and removed request for a team April 22, 2022 12:32
@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit febb627
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62666e5ab39f100008fc5dc4
😎 Deploy Preview https://deploy-preview-416--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shortcuts shortcuts enabled auto-merge (squash) April 22, 2022 12:32
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 22, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts disabled auto-merge April 22, 2022 12:45
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants