Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(javascript): allow overriding all transporter options #615

Merged
merged 3 commits into from
Jun 1, 2022
Merged

feat(javascript): allow overriding all transporter options #615

merged 3 commits into from
Jun 1, 2022

Commits on May 31, 2022

  1. feat(javascript): allow overriding all transporter options 

    In v4 these are all allowed, and this allows users to work around possible issues we have smoothly, see eg. algolia/react-instantsearch#3487

At the same time I also simplified the passing of options in node/browser, they were double checking a variable that later overrides the original with the spread anyway.
    @Haroenv
    Haroenv committed May 31, 2022
    Configuration menu
    Copy the full SHA
    5cd3fe3 View commit details
    Browse the repository at this point in the history

  2. make tests pass by avoiding shadowing

    @Haroenv
    Haroenv committed May 31, 2022
    Configuration menu
    Copy the full SHA
    4b3cd32 View commit details
    Browse the repository at this point in the history

  3. oh yes this too

    @Haroenv
    Haroenv committed May 31, 2022
    Configuration menu
    Copy the full SHA
    11fbe8d View commit details
    Browse the repository at this point in the history