Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(javascript): simplify transporter.request #617

Merged
merged 1 commit into from
Jun 1, 2022
Merged

refactor(javascript): simplify transporter.request #617

merged 1 commit into from
Jun 1, 2022

Commits on May 31, 2022

  1. refactor(javascript): simplify transporter.request 

    I can't see any significant difference between the first and second argument of `request`, so this PR changes that to both be in the first argument. requestOptions is still separate.

Other API clients don't seem to distinguish that clearly in the arguments to sendRequest, as they use mostly positional arguments

PHP: https://github.com/algolia/api-clients-automation/blob/bf4271246f9282d3c11dd46918e74cb86d9c96dc/templates/php/api.mustache#L263

Java: https://github.com/algolia/api-clients-automation/blob/bf4271246f9282d3c11dd46918e74cb86d9c96dc/templates/java/libraries/okhttp-gson/api.mustache#L196
    @Haroenv
    Haroenv committed May 31, 2022
    Configuration menu
    Copy the full SHA
    3cf28c2 View commit details
    Browse the repository at this point in the history