fix(javascript): check that appId, apiKey and region are valid parameters APIC-505 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
damcou
approved these changes
Jun 3, 2022
| @@ -6,7 +6,7 @@ import { create{{capitalizedApiName}} } from '../src/{{apiName}}'; | |||
| import type { {{capitalizedApiName}} } from '../src/{{apiName}}'; | |||
|
|
|||
| {{#hasRegionalHost}} | |||
| import type { Region } from '../src/{{apiName}}'; | |||
| import { Region, REGIONS } from '../src/{{apiName}}'; | |||
There was a problem hiding this comment.
I guess there's no way to prevent duplication here ?
There was a problem hiding this comment.
we could infer the type here again but as it's already done at the creation there is no point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-505
Check the parameters in a basic way, and check that region is within the enum.
🧪 Test
CI