fix(javascript): remove factory from build #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
requested review from
a team,
eunjae-lee and
millotp
and removed request for
a team
millotp
approved these changes
Jun 6, 2022
Comment on lines
+26
to
+35
| {{#operations}} | ||
| import type { | ||
| {{#operation}} | ||
| {{#vendorExtensions.x-create-wrapping-object}} | ||
| {{#lambda.titlecase}}{{nickname}}{{/lambda.titlecase}}Props, | ||
| {{/vendorExtensions.x-create-wrapping-object}} | ||
| {{/operation}} | ||
| } from '../model/clientMethodProps'; | ||
| {{/operations}} | ||
|
|
There was a problem hiding this comment.
import * is not enough here ?
There was a problem hiding this comment.
If we give it an alias we would have to change all methods to use Alias.TypeName so I thought it was less verbose to do it at the import level, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-506
Changes included:
We were exposing the factory function in the final build, which could be confusing for a user when importing the client using IDE autocompletion.
We now move the method props to a
clientMethodPropsmodel file.Side changes:
searchclient foralgoliasearchalgoliasearchclient🧪 Test
CI :D