fix(javascript): remove duplicate types, add some type descriptions #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Jun 7, 2022
| readonly headers: () => Readonly<Record<string, string>>; | ||
| readonly queryParameters: () => Readonly<Record<string, string>>; | ||
| readonly headers: () => Headers; | ||
| readonly queryParameters: () => QueryParameters; |
There was a problem hiding this comment.
the QueryParameters type should be stricter IMO, it should be Record<string | number | boolean | Array<string | number | boolean>> (I think we already have this type somewhere).
In serializeQueryParameters we also accept Object, I'm sure if we ever use it in the api
There was a problem hiding this comment.
IIRC I've went with a stricter type when adding the requestOptions but since it was any in v4 I've followed the same implem
clients/algoliasearch-client-javascript/packages/client-common/src/types/Requester.ts
Outdated
Show resolved
Hide resolved
millotp
approved these changes
Jun 7, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jun 7, 2022
algolia/api-clients-automation#644 Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
🧪 Test
CI :D