fix(javascript): remove duplicate echoRequester logic
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
a team,
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
commented
Jun 8, 2022
| @@ -1,8 +1,8 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
| /* eslint-disable require-await */ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars, require-await */ | |||
| // @ts-nocheck Failing tests will have type errors, but we cannot suppress them even with @ts-expect-error because it doesn't work for a block of lines. | |||
There was a problem hiding this comment.
With this new template we could maybe scope the TS error now 🤔
millotp
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-507
Changes included:
The scope of the task has changed since the
echoRequesteris not used in the client package, so not in the final UMD build and no impact on the size.In this PR we:
🧪 Test
CI :D