fix(clients): rename maxTrial to maxRetries
#659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
Ah yes #616 only renamed to message |
|
I've added https://algolia.atlassian.net/browse/APIC-524 as we had outdated deps in our mustache files that cause common tests to fail Looking at it, it also highlights that the cache/run condition is too loose for those utils, as test had not ran in previous PRs |
eunjae-lee
reviewed
Jun 9, 2022
| @@ -313,6 +313,41 @@ describe('createReleasePR', () => { | |||
| expect(versions.java.next).toEqual('0.0.2'); | |||
| }); | |||
|
|
|||
| it('releases every languages if a `clients` commit is present', () => { | |||
There was a problem hiding this comment.
awesome that you didn't forget this part 🙌
millotp
approved these changes
Jun 9, 2022
| @@ -54,8 +54,8 @@ async function updateVersionForJavascript( | |||
| }); | |||
|
|
|||
| await fsp.writeFile( | |||
| toAbsolutePath('config/openapitools.json').concat('\n'), | |||
| JSON.stringify(openapiConfig, null, 2) | |||
| toAbsolutePath('config/openapitools.json'), | |||
There was a problem hiding this comment.
me that missed yesterday I believe :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Spotted by #564 (comment), it seems that only PHP had the renamed version
Other changes in this PR:
clientsscope title, same asspecsso it releases all clients🧪 Test
CI :D