fix(specs): issue with SearchParams and IndexSettings types and parameters
#708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
fix/specs-types-and-parameters
branch
from
f25e02f
to
be82cfb
Compare
shortcuts
changed the title
SearchParams and IndexSettings types and parameters
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
shortcuts
force-pushed
the
fix/specs-types-and-parameters
branch
from
be82cfb
to
2a026ed
Compare
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
millotp
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-542
Changes included:
Fix some parameters around the
SearchParamsandIndexSettings. Some of them were in the wrong "category", some were wrongly typed.🧪 Test
CI :D