Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): import lite resolution #737

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 23, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-549

Changes included:

@Haroenv reported that lite path was not correctly resolved when importing from Parcel 1 (and potentially others), this small addition should fix it.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team June 23, 2022 14:58
@shortcuts shortcuts self-assigned this Jun 23, 2022
@shortcuts shortcuts requested review from damcou and millotp and removed request for a team June 23, 2022 14:58
@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 4380ef9
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62b47f7ad377470008466eb2

@shortcuts shortcuts enabled auto-merge (squash) June 23, 2022 14:58
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 23, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈 js magic 🌈

@shortcuts
Copy link
Member Author

🌈 js magic 🌈

image

@shortcuts shortcuts merged commit d7fcc6d into main Jun 23, 2022
@shortcuts shortcuts deleted the fix/javascript-import-lite branch June 23, 2022 15:11
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 23, 2022
algolia/api-clients-automation#737

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants