Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(javascript): provide requestOptions to helper methods #797

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix(javascript): provide requestOptions to helper methods #797

merged 1 commit into from
Jul 6, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

We've agreed on providing the requestOptions to the helper methods, but JavaScript was missing it

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team July 6, 2022 12:51
@shortcuts shortcuts self-assigned this Jul 6, 2022
@shortcuts shortcuts requested review from damcou and millotp and removed request for a team July 6, 2022 12:51
@netlify
Copy link

netlify bot commented Jul 6, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 84433cb
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62c5888ac0018100080becb4

@shortcuts shortcuts mentioned this pull request Jul 6, 2022
Merged
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 6, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

damcou
damcou approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shortcuts shortcuts merged commit 750721d into main Jul 6, 2022
@shortcuts shortcuts deleted the fix/js-helper-methods branch July 6, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shortcuts @algolia-bot @damcou