fix(javascript): build

[shortcuts]

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-618

Problem

• We have a lot of custom logic for the JS build, leveraging an existing tool should prevent unwanted issue/fixes
• Dependencies needs to be built first, e.g. first CI run of https://github.com/algolia/api-clients-automation/pull/900
• Build output of the algoliasearch/lite client is not correct (double nested folder)

Changes included:

Leverage Lerna + Nx as our building tool for the JavaScript client, which allow us to:

• Cache build processes (only works locally for now)
• Let lerna handle dependencies and build order
• Remove some custom logic
• Fix the wrong built destination of the algoliasearch client, resulting in duplicate types and nested lite/lite folder

Cache does not seem to trigger on the CI but time seems to be more consistent.

Rollup config:

There is build-related changes in the rollup config other than the map logic to save previously built types (checkForTypes). The core logic that previously was in clients/algoliasearch-client-javascript/rollup.config.js have been merged with the base.rollup.config, and some logic have changed to handle the per-client build logic.

🧪 Test

1. checkout to generated/fix/js-build
2. cd clients/algoliasearch-client-javascript && yarn build:all
3. (optional) test any of the other build commands

[netlify]

✅ Deploy Preview for api-clients-automation canceled.

Name	Link
🔨 Latest commit	5d17278
🔍 Latest deploy log	https://app.netlify.com/sites/api-clients-automation/deploys/62f223d7cc423f00090b7945

[algolia-bot]

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

[shortcuts]

cc @millotp if you want to check when you come back

[bodinsamuel]

Why not 👍🏻
I could not test

~ yarn build:all                                                                                                    0 [16:01:45]
lerna notice cli v5.3.0
lerna info versioning independent
lerna notice filter excluding "{@algolia/requester-*,@algolia/client-common}"
lerna info filter [ '!{@algolia/requester-*,@algolia/client-common}' ]
lerna success run No packages found with the lifecycle script 'build'

[shortcuts]

I could not test

I've added in the PR body test to checkout the generated branch, so the build command appears in each packages

[bodinsamuel]

I've added in the PR body test to checkout the generated branch, so the build command appears in each packages

Yep this is the one I tried and didn't work. It might require additional generation?

[shortcuts]

Yep this is the one I tried and didn't work. It might require additional generation?

Hm it shouldn't 🤔 that's the same that is used on the CI and for my tests. Maybe a yarn install but nothing more, I'll start from scratch and try myself to see if it correctly works

edit: seems to work correctly on my side

[bodinsamuel]

not sure what changed but works now 👍🏻

[shortcuts]

not sure what changed but works now 👍🏻

nothing related to how the build works but glad to hear it :D