Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): allow providing options for node requester #872

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 26, 2022

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

I discovered during the Crawler implementation that it was already possible in v4 to override those options, but was not introduced here.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 26, 2022
@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5a5b6fc
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62e0f2ce81b68e000a284dfe
😎 Deploy Preview https://deploy-preview-872--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 26, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

bodinsamuel
bodinsamuel previously approved these changes Jul 27, 2022
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes very important !

Base automatically changed from fix/specs-hits to main July 27, 2022 08:08
@shortcuts shortcuts enabled auto-merge (squash) July 27, 2022 08:10
@shortcuts shortcuts disabled auto-merge July 27, 2022 08:26
@shortcuts shortcuts merged commit 0d988f9 into main Jul 27, 2022
@shortcuts shortcuts deleted the fix/js-requester-override branch July 27, 2022 08:26
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants