Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): make type filename consistent #890

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 3, 2022

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

TypeScript filenames of the client-common package are not consistent with what we exposed in the other clients, in this PR the files are renamed to camelCase.

🧪 Test

@shortcuts shortcuts self-assigned this Aug 3, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 060f07b
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ea7ac5031102000870c5fb
😎 Deploy Preview https://deploy-preview-890--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 3, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

damcou
damcou previously approved these changes Aug 3, 2022
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this 👍

@shortcuts shortcuts changed the base branch from fix/specs-keys-rules to main August 3, 2022 13:42
@shortcuts shortcuts dismissed damcou’s stale review August 3, 2022 13:42

The base branch was changed.

@shortcuts shortcuts requested a review from damcou August 3, 2022 13:42
@shortcuts shortcuts enabled auto-merge (squash) August 3, 2022 13:42
@shortcuts shortcuts merged commit 2c7cd9c into main Aug 3, 2022
@shortcuts shortcuts deleted the fix/js-ts-filename branch August 3, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants