Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): helpers type options #895

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 4, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-609

Changes included:

  • waitFor* types were wrong (shouldn't require maxRetries and timeout)
  • State default in JSDoc for browse* methods
  • Add @alpha tag to installation guides

🧪 Test

  • yarn docker playground javascript search to test on the playground

@shortcuts shortcuts requested a review from damcou August 4, 2022 07:15
@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit f2cebf3
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62eb7207d04a7c0009e07cd1
😎 Deploy Preview https://deploy-preview-895--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 4, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts self-assigned this Aug 4, 2022
@shortcuts shortcuts merged commit 9753e2d into main Aug 4, 2022
@shortcuts shortcuts deleted the fix/js-helpers-type branch August 4, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants