feat(specs): bundle specs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
89fb5fd
to
6661f97
Compare
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
989f514
to
6ac448c
Compare
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
90fa71d
to
534bf72
Compare
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
534a011
to
ba7b470
Compare
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
ace5839
to
bf89275
Compare
shortcuts
requested review from
a team and
damcou
and removed request for
a team
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
21153c7
to
ae651da
Compare
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
7ee442a
to
6ebff90
Compare
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
6ebff90
to
a1a9a7f
Compare
millotp
reviewed
Jan 17, 2022
Comment on lines
+20
to
+21
| '404': | ||
| $ref: ../../../common/responses/IndexNotFound.yml |
There was a problem hiding this comment.
I don't think this error makes sense, as there is not indexName in the request (same thing for others endpoint where you added 404)
There was a problem hiding this comment.
It was for the sake of making the linter pass, but as errors does not work yet, I believe we should have a proper task to fix all of those issue
There was a problem hiding this comment.
Yes we will definitely forget otherwise.
There was a problem hiding this comment.
Created https://algolia.atlassian.net/browse/APIC-265 with a high priority for the next sprint
shortcuts
force-pushed
the
feat/APIC-256/specs-bundle
branch
from
db67641
to
9283d9e
Compare
millotp
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃Л What and Why
馃師 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-256
Changes included:
We previously had issue with our specs due to path being too complex/deep. This PR introduces a new tool to bundle/lint specs properly.
summaryto specs.builtInOperations.馃И Test
CI :D