Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): correct searchParams with cursor for browse method #911

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-617

Changes included:

Not only query strings are accepted for the browse methods, but search params too.

🧪 Test

  • playground with browse method implementation

@shortcuts shortcuts requested a review from damcou August 9, 2022 08:43
@shortcuts shortcuts self-assigned this Aug 9, 2022
@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit c979b7a
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62f2335e4535f40008c4598b
😎 Deploy Preview https://deploy-preview-911--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shortcuts shortcuts enabled auto-merge (squash) August 9, 2022 08:43
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 9, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts changed the title fix(specs): allow searchParams in browse method fix(specs): correct searchParams with cursor for browse method Aug 9, 2022
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shortcuts shortcuts merged commit c2a054f into main Aug 9, 2022
@shortcuts shortcuts deleted the fix/specs-browse-searchparams branch August 9, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants