Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): allow undefined object when all parameters are optional #922

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Discovered during Crawler implementation.

Some methods only have optional parameters, but still require an empty object as a parameter, which is not an ideal DX.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from damcou August 12, 2022 10:24
@shortcuts shortcuts self-assigned this Aug 12, 2022
@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit a15b7f7
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62f62a74d159e2000937b855

@shortcuts shortcuts enabled auto-merge (squash) August 12, 2022 10:25
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 12, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shortcuts shortcuts merged commit 5100204 into main Aug 12, 2022
@shortcuts shortcuts deleted the fix/js-allow-undefined-object branch August 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants