Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): update Predict type exports #953

Merged
merged 8 commits into from
Aug 26, 2022
Merged

Conversation

francoischalifour
Copy link
Member

🧭 What and Why

Changes included:

  • rename Affinities to Affinity
  • export Region and add description
  • make model types' (Affinities, FunnelStage) keys required (they shouldn't be optional)
  • export ModelsToRetrieve as ModelsToRetrieveEnum[]
  • export TypesToRetrieve as TypesToRetrieveEnum[]

🧪 Test

None added.

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit a514304
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/630889d9b09d7700082cece3
😎 Deploy Preview https://deploy-preview-953--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 25, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@francoischalifour francoischalifour changed the title fix(predict): update type exports fix(javascript): update Predict type exports Aug 25, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shortcuts shortcuts enabled auto-merge (squash) August 26, 2022 08:59
@shortcuts shortcuts merged commit a5ee875 into main Aug 26, 2022
@shortcuts shortcuts deleted the fix/predict-specs branch August 26, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants