Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): create new methods #974

Merged
merged 20 commits into from
Sep 1, 2022
Merged

feat(specs): create new methods #974

merged 20 commits into from
Sep 1, 2022

Conversation

bengreenbank
Copy link
Contributor

🧭 What and Why

I am adding 2 new methods to the Predict API clients:

  • Delete a user
  • View all users

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/PRED-545?atlOrigin=eyJpIjoiMjdmZmRhZjBiZTg3NGU3YWI3Y2UzZDQ2Y2Q2YzhmOTYiLCJwIjoiaiJ9

Changes included:

  • Create both specs
  • Move 'user profile' to common
  • Add pagination parameters
  • Move some errors to common

🧪 Test

Use new endpoints with credentials to test for a response.

@bengreenbank bengreenbank added the enhancement New feature or request label Aug 30, 2022
@bengreenbank bengreenbank self-assigned this Aug 30, 2022
@netlify
Copy link

netlify bot commented Aug 30, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit b0a5eff
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/631098821d6bcc0008427ac0

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 30, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@bengreenbank bengreenbank changed the title feat(predict): create new methods [PRED-545] feat(specs): create new methods [PRED-545] Aug 30, 2022
@shortcuts shortcuts mentioned this pull request Aug 30, 2022
Merged
shortcuts
shortcuts reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review until #975 fixes your build issue

Also, the PR title is used in the changelog, we usually don't put the Jira ticket in it

specs/predict/common/schemas/Params.yml Outdated Show resolved Hide resolved
@bengreenbank bengreenbank changed the title feat(specs): create new methods [PRED-545] feat(specs): create new methods Aug 30, 2022
shortcuts
shortcuts reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great already!

specs/predict/common/schemas/Params.yml Outdated Show resolved Hide resolved
specs/predict/paths/users/fetch.yml Outdated Show resolved Hide resolved
shortcuts
shortcuts previously approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good on the API side, do we wait for a review from the Predict team?

@bengreenbank
Copy link
Contributor Author

Seems good on the API side, do we wait for a review from the Predict team?

@francoischalifour feel free to leave a review if you wish

@bengreenbank bengreenbank requested a review from a team as a code owner September 1, 2022 10:16
millotp
millotp approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@shortcuts shortcuts enabled auto-merge (squash) September 1, 2022 11:33
@shortcuts
Copy link
Member

I'll release once the changes have been pushed to main, thanks for the PR!

@shortcuts shortcuts merged commit 80724c1 into main Sep 1, 2022
@shortcuts shortcuts deleted the feat/predict branch September 1, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

@millotp millotp millotp approved these changes

@shortcuts shortcuts shortcuts approved these changes

Assignees

@bengreenbank bengreenbank

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bengreenbank @algolia-bot @shortcuts @francoischalifour @millotp