Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chrome-only): Change autocomplete from 'nope' to 'off' #273

Merged
merged 3 commits into from
Dec 11, 2018

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Dec 10, 2018

Reverts #250

see also #247 and fbbed04

cc @SchmidtDawid @Braunson @sdwvit

I could replicate this updated version behaving not as expected in Chrome, but also in Safari. Going back to a value as written in the specification (off) seems like the way to go for this.

@Haroenv Haroenv requested a review from a team December 10, 2018 13:47
@Haroenv
Copy link
Contributor Author

Haroenv commented Dec 10, 2018

We should probably make this an option, since it's so conflicting between versions.

@coveralls
Copy link

coveralls commented Dec 10, 2018

Coverage Status

Coverage remained the same at 88.959% when pulling 708cb5f on revert-250-patch-1 into fc9a3b4 on master.

@sdwvit
Copy link
Contributor

sdwvit commented Dec 10, 2018

@Haroenv totally agree.
Since chrome does not respect flag, there is only one thing you can do - generate unique hash and append it to the 'name' attribute value, effectively busting chrome autocomplete cache.

@Braunson
Copy link

I think both @Haroenv and @sdwvit both have valid solutions and we should use both. Allow a flag to define the autocomplete value but you should also use unique hashes in your attribute name (when possible).

@Haroenv
Copy link
Contributor Author

Haroenv commented Dec 11, 2018

I'll add a way to customise this after

@Haroenv Haroenv merged commit 892a8f0 into master Dec 11, 2018
@Haroenv Haroenv deleted the revert-250-patch-1 branch December 11, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants