Fix(chrome-only): Change autocomplete from 'off' to 'nope' #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdwvit
changed the title
|
Thanks! I'll take a look and see the impact of this |
|
Could this get merged? Running in this problem as well with places.js. |
|
@mbardelmeijer & @sdwvit, sorry for the delay here; I have released this as 0.34.0 because I finally had time to confirm it worked as I expected yesterday |
Haroenv
added a commit
that referenced
this pull request
Dec 11, 2018
|
Can 0.35.0 be tagged with the reverted code? |
|
has been released @king724 |
|
Thank you!! |
|
for future reference, you could have used 0.33.0 without issue if you were having the issue @king724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fight chrome's non-standard behaviour on inputs.
fixes: #247
See above issue to get more context.
ToDo: regenerate dist files