Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete-js has missing peer dependency on algoliaserch #1094

Closed
andrei-picus-tink opened this issue Feb 14, 2023 · 2 comments · Fixed by #1095
Closed

autocomplete-js has missing peer dependency on algoliaserch #1094

andrei-picus-tink opened this issue Feb 14, 2023 · 2 comments · Fixed by #1095

Comments

@andrei-picus-tink
Copy link

Description

Installing autocomplete-js with yarn@3 produces a peer dependency warning:

➤ YN0002: │ @algolia/autocomplete-js@npm:1.8.0 [1291c] doesn't provide algoliasearch (p2a0a2), requested by @algolia/autocomplete-preset-algolia

According to https://yarnpkg.com/advanced/error-codes#yn0002---missing_peer_dependency:

The author of [autocomplete-js] can fix this problem by adding a peer dependency on [algoliasearch]. If relevant, they can use optional peer dependencies to this effect.

Reproduction

yarn set version berry
yarn add @algolia/autocomplete-js @algolia/client-search

autocomplete-js depends on preset-algolia which peer depends on algoliasearch, but does not provide it itself.

Expected behavior

Dependencies install without warnings.

Environment

  • Yarn: 3.4.1
  • Autocomplete version: 1.8.0
@Haroenv
Copy link
Contributor

Haroenv commented Feb 14, 2023

I've made a fix in #1095 which will be included in the next release in the coming weeks (the last release was just hours ago, so I'll leave this a bit until another useful feature is added

@andrei-picus-tink
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants