feat(createAlgoliaInsightsPlugin): automatically load Insights when not passed #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
commented
Mar 8, 2023
| positions?: number[]; | ||
| }; | ||
|
|
||
| type QueueItemMap = Record<string, unknown>; |
There was a problem hiding this comment.
This could be more strictly typed, but it requires updating TypeScript, which then triggers other type issues.
Let's handle this in another PR.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6a51c83:
|
sarahdayan
commented
Mar 8, 2023
Comment on lines
+236
to
+245
| script.onerror = () => { | ||
| // eslint-disable-next-line no-console | ||
| console.error(errorMessage); | ||
| }; | ||
|
|
||
| document.body.appendChild(script); | ||
| } catch (cause) { | ||
| // eslint-disable-next-line no-console | ||
| console.error(errorMessage); | ||
| } |
There was a problem hiding this comment.
Not a huge fan of using console.errors but since there's no global error handler in Autocomplete, throwing would be hardly catchable for users.
I'd rather use those now (Sentry lets you catch calls to the Console API) and work on an onError handler in a separate PR to centralize error handling.
Haroenv
reviewed
Mar 8, 2023
packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-plugin-algolia-insights/src/types/InsightsClient.ts
Show resolved
Hide resolved
Haroenv
approved these changes
Mar 9, 2023
dhayab
reviewed
Mar 9, 2023
packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
Show resolved
Hide resolved
dhayab
approved these changes
Mar 13, 2023
Haroenv
pushed a commit
that referenced
this pull request
Apr 7, 2023
Haroenv
pushed a commit
that referenced
this pull request
Apr 24, 2023
Haroenv
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically loads the Insights library when using the Insights plugin without passing a client.
The
insightsClientparameter is now optional, allowing us to later initialize the plugin internally without a client if we can't find one on the page.FX-2245