Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): forward insights usertoken to algolia api calls #1179

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Aug 11, 2023

This PR forwards generated or explicitly set user tokens from the Insights library to Algolia queries sent through getAlgoliaResults().

@dhayab dhayab requested review from a team, sarahdayan, aymeric-giraudet and Haroenv and removed request for a team August 11, 2023 08:57
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4561233:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically we can read the cookie like in InstantSearch before insights loads, but this is good too

@dhayab dhayab merged commit 7a71eb4 into next Aug 11, 2023
9 checks passed
@dhayab dhayab deleted the feat/insights-forward-usertoken branch August 11, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants