Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Insights opt-in from the Dashboard #1205

Merged
merged 19 commits into from Oct 25, 2023

Conversation

sarahdayan
Copy link
Member

@sarahdayan sarahdayan commented Oct 16, 2023

Summary

This enables Insights opt-in from the Dashboard.

Algolia customers can now opt-in to Automatic Insights directly from the Dashboard instead of having to pass the insights option to true in the code.

FX-2644

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b3bc8d:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@sarahdayan sarahdayan marked this pull request as ready for review October 16, 2023 16:17
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have listed some questions and suggestions before approving.

packages/autocomplete-core/src/createAutocomplete.ts Outdated Show resolved Hide resolved
packages/autocomplete-core/src/createAutocomplete.ts Outdated Show resolved Hide resolved
packages/autocomplete-core/src/onInput.ts Outdated Show resolved Hide resolved
@sarahdayan
Copy link
Member Author

Thanks for the review @dhayab! I took your feedback into account and also made a small change to never send clickAnalytics=false but rather not send it when the plugin is initialized not to pass it. This will avoid disabling Dashboard opt-in by forcing clickAnalytics to false in the request (e0a2c3b).

Copy link

@jonathaningram jonathaningram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 🙏🏻

@sarahdayan sarahdayan enabled auto-merge (squash) October 25, 2023 12:05
@sarahdayan sarahdayan merged commit 77c2aff into next Oct 25, 2023
9 checks passed
@sarahdayan sarahdayan deleted the feat/dashboard-insights branch October 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants