Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant search #5

Closed
maxiloc opened this issue Jul 13, 2015 · 9 comments
Closed

Instant search #5

maxiloc opened this issue Jul 13, 2015 · 9 comments

Comments

@maxiloc
Copy link
Contributor

maxiloc commented Jul 13, 2015

Until recently 😄 typeahead was out default autocompletion implementation for us. I think now that we have this repo, it could be very cool that it could be our instant search default implementation. I think this is THE the place where we could unify all our integration instant implementation.

I have several points where I am not sure how we can implement that in a generic customizable way. But I sure we will manage.

I am thinking of an instant implementation that will look like this :

$("#instant_search_input").instant({
  "container": "#instant_search_container",
  "content_template": "#instant_search_content",
  [...]
});

Obviously there is a lot to discuss

Do you think this could make sense ?

@redox
Copy link
Contributor

redox commented Jul 13, 2015

I'm convinced we need more libraries to tackle the search UI problem (and we've already started to investigate what we can do with ui-kit) but we probably need another repository for that. This auto-completion library will be a dependency of it as well as an URL manager, a Slider widget, some conjunctive/disjunctive/hierarchical facet widgets, etc...

@maxiloc
Copy link
Contributor Author

maxiloc commented Jul 13, 2015

Ok that make sense.

@redox
Copy link
Contributor

redox commented Jul 14, 2015

Let's close it for now then.

@redox redox closed this as completed Jul 14, 2015
@pixelastic
Copy link
Contributor

Sorry I didn't really get it.

Are you saying that this autocomplete.js is part of a larger family of instant-search.js, slider.js and url-manager.js libraries we'll build ? Each one handling one UI use-case ?

@redox
Copy link
Contributor

redox commented Jul 15, 2015

Yes, something like that. What do you think? (it will not be slider.js but rather facet.slider.js -> all those components will be very Algolia centric).

@pixelastic
Copy link
Contributor

Hmm yes, that could work I guess. Each of this library having a clear UI role.

This still make me wonder:

  • What about the ui-kit ? Will we split it in several libraries ?
  • What about logic code (like hierarchical category facetting) ? Should it be handled by the helper or the facet.hierarchical.js new library ?

I don't have a clear answer to that, just throwing it here. I think I'd rather have the helper with all the logic but no UI, and then several libraries only handling the UI.

@redox
Copy link
Contributor

redox commented Jul 15, 2015

What about the ui-kit ? Will we split it in several libraries ?

Yeah, we still need to discuss about it with @bobylito; here the goal would be to create reusable UI components for developers. The ui-kit is more about creating a search UI without code.

I don't have a clear answer to that, just throwing it here. I think I'd rather have the helper with all the logic but no UI, and then several libraries only handling the UI.

Yes 👍

@vvo
Copy link
Contributor

vvo commented Jul 15, 2015

We need the ui kit features exposed as a programmatic API, so first we should describe and iterate on the API we want to provide

@vvo
Copy link
Contributor

vvo commented Jul 15, 2015

The ultimate goal wpild be to be able to use this programmatic API without having to embed and configure both the client and helper, this should all be handled by the ui.js

FezVrasta pushed a commit to FezVrasta/autocomplete.js that referenced this issue Jan 31, 2020
…name_template

feat(autocomplete): append classNames on template after sources
FezVrasta pushed a commit to FezVrasta/autocomplete.js that referenced this issue Jan 31, 2020
…tically (algolia#8)

* fix(reset): fix reset when there are no results

* feat(dropdown): let user override shouldDropdownOpen based on the Autocomplete's state

* story(classNames): remove superfluous debugging log

* refactor(Autocomplete): revert wrong new statement

* refactor(gitignore): ignore IDEA folders

* story(shouldDropdownOpen): add dedicated story

* doc(fix): add missing doc from algolia#5

* refactor(sotries): remove superfluous class

* refactor(stories): fix typo

* refactor(autocomplete): fix typo

* refactor(story): better readibility

* Update README.md

Co-Authored-By: François Chalifour <francoischalifour@users.noreply.github.com>

* Update README.md

Co-Authored-By: François Chalifour <francoischalifour@users.noreply.github.com>

* Update README.md

Co-Authored-By: François Chalifour <francoischalifour@users.noreply.github.com>

* Update src/types.ts

Co-Authored-By: François Chalifour <francoischalifour@users.noreply.github.com>

* refactor(stories): simplify story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants