New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same default image name #288

Closed

LeoErcolanelli opened this issue May 23, 2016 · 1 comment

Contributor

LeoErcolanelli commented May 23, 2016

Here: https://github.com/algolia/docsearch-scraper/blob/master/cli/src/commands/build_docker_scraper.py#L11-L18

All containers are built with the same name because of the optional argument here: https://github.com/algolia/docsearch-scraper/blob/master/cli/src/commands/abstract_command.py#L21

Is it to be expected?

LeoErcolanelli mentioned this issue

Name built images differently #289

Merged

Contributor Author

LeoErcolanelli commented May 23, 2016

PR here #289

LeoErcolanelli closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment