fix(dependencies): upgrade dependencies #1015
Conversation
| }, | ||
| ], | ||
| }) | ||
| return searchClient |
There was a problem hiding this comment.
With the new Autocomplete Requester API, it's easier for us to use the client to create sources on the fly.
| @@ -13,11 +13,11 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@algolia/ui-library": "2.35.0", | |||
| "@docsearch/react": "1.0.0-alpha.28", | |||
| "@docsearch/react": "3.0.0-alpha.36", | |||
There was a problem hiding this comment.
This website package isn't the live https://docsearch.algolia.com/ one, I've updated the dependencies just to make it consistent.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2c0ba3:
|
| @@ -0,0 +1,19 @@ | |||
| import React from 'react'; | |||
| import { DocSearch } from '@docsearch/react'; | |||
There was a problem hiding this comment.
this has a lint error, I guess because it's a local file and a wrong error / missing eslint configuration?
There was a problem hiding this comment.
It indeed is, AFAIK it's been failing for a long time, I'll fix it in a future PR
Summary
This PR upgrade the DocSearch dependencies but most importantly Autocomplete to the latest version, which fixes this issue: facebook/docusaurus#5031
Without any query, recent searches and favorite searches, DocSearch crashes the whole website when pressing ↑ with the input focused.
Reproduction:
recent searchesandfavorite searchesif there's any.Result