Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): enable outline for focus state #1732

Merged
merged 1 commit into from Dec 27, 2022

Conversation

chenxsan
Copy link
Contributor

Closes #1731

Users of DocSearch can always customize as needed.

@netlify
Copy link

netlify bot commented Dec 27, 2022

Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 5e2add9
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/63aad071009b340008333659

@shortcuts
Copy link
Member

can confirm it works well on the playground, for both JS and React, looks much better!

Screenshot 2022-12-27 at 12 25 19

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting the issue and fixing it!

@shortcuts shortcuts merged commit f7a8bde into algolia:main Dec 27, 2022
@chenxsan chenxsan deleted the bugfix/fix-focus-state branch December 27, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't focus on the clear button with tab key
2 participants